Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ParameterEventsSubscriber class #829
Add ParameterEventsSubscriber class #829
Changes from 29 commits
6473041
3246e34
cdf4156
72817ab
884a2d8
f189327
a010d2d
f67d829
12329bf
921d2b4
7c19dbb
9cc41c7
2559434
0d5d75c
e4bc1d8
f360350
36e0190
e41f75c
b3b683f
8fb32de
60533db
ab4ff32
894da98
3404ec9
d4128de
1201f4f
18e72cf
e08612c
a4f5533
cbc8989
f011c3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: There is a stream operator for parameters:
rclcpp/rclcpp/include/rclcpp/parameter.hpp
Lines 224 to 226 in b9ffd72
rclcpp/rclcpp/src/rclcpp/parameter.cpp
Lines 175 to 180 in b9ffd72
rclcpp/rclcpp/src/rclcpp/parameter.cpp
Lines 189 to 197 in b9ffd72
Which you could use like this (test it because I'm not 100% sure on the syntax):
So long as the format is what you want. Just a suggestion, feel free to ignore it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpwilcox we're investigating some strange behavior and this class is involved, but during that investigation I noticed this mutex is recursive, but it wasn't immediately obvious to me why that's required. The callback is used in a subscription which is used in a mutually exclusive callback group (the default) and so it will never be called in parallel with itself. Likewise I don't see why any of the other functions (add/remove ones) use the mutex in a way where recursion is needed.
I know this is an ancient issue, but it was just a shot in the dark if you remembered why that was the case.