Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break Node into several separate interfaces #277

Merged
merged 38 commits into from
Dec 10, 2016
Merged

break Node into several separate interfaces #277

merged 38 commits into from
Dec 10, 2016

Commits on Dec 8, 2016

  1. add the NodeBaseInterface and impl NodeBase

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    5133756 View commit details
    Browse the repository at this point in the history

  2. refactor rclcpp to use NodeBaseInterface

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    e1e9709 View commit details
    Browse the repository at this point in the history

  3. triggering a guard condition is not const

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    a9947d5 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary pure virtual destructor

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    4fd3ef2 View commit details
    Browse the repository at this point in the history

  5. remove unused private member, style

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    f205de7 View commit details
    Browse the repository at this point in the history

  6. create NodeTopics interface, refactor pub/sub

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    242f459 View commit details
    Browse the repository at this point in the history

  7. add convenience functions to fix API breaks

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    68ccfa6 View commit details
    Browse the repository at this point in the history

  8. fix compilation errors from NodeTopics refactor

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    b63b960 View commit details
    Browse the repository at this point in the history

  9. move "Event" based exceptions to exceptions.hpp

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    aafb440 View commit details
    Browse the repository at this point in the history

  10. add the NodeGraphInterface and related API's

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    db5e0eb View commit details
    Browse the repository at this point in the history

  11. update node and graph_listener to use NodeGraph API

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    778dedc View commit details
    Browse the repository at this point in the history

  12. initialize node_topics_ and node_graph_ in Node

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    36a206a View commit details
    Browse the repository at this point in the history

  13. remove methods from Node and reorganize the order 

    the removed methods are really low level and still
available via their respective Node*Interface class
    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    8a61d74 View commit details
    Browse the repository at this point in the history

  14. add the NodeServices API and implementation

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    40cfa22 View commit details
    Browse the repository at this point in the history

  15. add the NodeParameters API and refactor Node

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    345a137 View commit details
    Browse the repository at this point in the history

  16. mixups

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    36e746b View commit details
    Browse the repository at this point in the history

  17. fixup NodeParameters constructor

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    c4cb6a2 View commit details
    Browse the repository at this point in the history

  18. added NodeTimers API and refactor Node

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    31e726f View commit details
    Browse the repository at this point in the history

  19. make new create_publisher and create_subscription free template funct… 

    …ions
    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    060b69b View commit details
    Browse the repository at this point in the history

  20. fixup

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    10631a9 View commit details
    Browse the repository at this point in the history

  21. fixup

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    c59b1d1 View commit details
    Browse the repository at this point in the history

  22. fixup

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    821a1ad View commit details
    Browse the repository at this point in the history

  23. fixup share pointer to node in any_executable

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    18db364 View commit details
    Browse the repository at this point in the history

  24. free env value before throwing on Windows

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    edac3ee View commit details
    Browse the repository at this point in the history

  25. uncrustify and cpplint

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    8507ac9 View commit details
    Browse the repository at this point in the history

  26. address constness issues

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    9fd2ad9 View commit details
    Browse the repository at this point in the history

  27. do not store the topic name as a std::string in subscription

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    9ad8342 View commit details
    Browse the repository at this point in the history

  28. fixes to support const char * topic name

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    6252e72 View commit details
    Browse the repository at this point in the history

  29. fix incomplete type specification, which fails on Windows

    @wjwwood
    wjwwood committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    7150837 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2016

  1. refactor after rebase from type support changes

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    1122e25 View commit details
    Browse the repository at this point in the history

  2. fixup Windows build

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    365705a View commit details
    Browse the repository at this point in the history

  3. fix template issues on Windows

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    dfa0cf7 View commit details
    Browse the repository at this point in the history

  4. uncrustify

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    053cd5b View commit details
    Browse the repository at this point in the history

  5. remove the unnecessary callback group argument from the add_publisher… 

    … func
    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    c18b6ab View commit details
    Browse the repository at this point in the history

  6. remove unnecessary using = directive

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    28a2cfc View commit details
    Browse the repository at this point in the history

  7. do not store node name in C++

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    83b610e View commit details
    Browse the repository at this point in the history

  8. fix client and service creation in Node constructor

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    f0afcab View commit details
    Browse the repository at this point in the history

  9. fix include orders

    @wjwwood
    wjwwood committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    23a7728 View commit details
    Browse the repository at this point in the history