Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed test_timers_manager clang warning #2479

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Removed test_timers_manager clang warning #2479

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
863dbe1
Removed test_timers_manager clang warning
ahcorde Apr 3, 2024
2b11988
Fix windows build
ahcorde Apr 3, 2024
720f4e9
make linters happy
ahcorde Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclcpp/test/rclcpp/test_timers_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ TEST_F(TestTimersManager, check_one_timer_cancel_doesnt_affect_other_timers)
// since typical users aren't going to mess around with the timer manager.
t1 = TimerT::make_shared(
1ms,
[&t1_runs, &t1, cancel_iter]() {
[&t1_runs, &t1]() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I knew this, but had to look it up again.

https://en.cppreference.com/w/cpp/language/lambda

A lambda expression can read the value of a variable without capturing it if the variable has const non-volatile integral or enumeration type and has been initialized with a constant expression

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea :). Today I learned something :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC doesn't seem to like it, though:

**09:25:11 C:\ci\ws\src\ros2\rclcpp\rclcpp\test\rclcpp\test_timers_manager.cpp(380,1): error C3493: 'cancel_iter' cannot be implicitly captured because no default capture mode has been specified [C:\ci\ws\build\rclcpp\test\rclcpp\test_timers_manager.vcxproj]
**

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set the default capture mode as it says?

Suggested change
[&t1_runs, &t1]() {
[=, &t1_runs, &t1]() {

t1_runs++;
if (t1_runs == cancel_iter) {
t1->cancel();
Expand Down