Primary state error transitions #1064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to errorProcessing Signed-off-by: thebyohazard <[email protected]>
thebyohazard
force-pushed
the
lifecycle_primary_state_error_transitions
branch
from
53b549b
to
3cc8bdf
Compare
fujitatomoya
requested changes
Nov 4, 2020
| const State & | ||
| LifecycleNode::raise_error() | ||
| { | ||
| if(get_current_state().id() == lifecycle_msgs::msg::State::PRIMARY_STATE_ACTIVE) |
There was a problem hiding this comment.
I do not think this needs to be checked here. it will check the current state and get the reference to rcl_lifecycle_transition_t in rcl state_machine.
| { | ||
| if(get_current_state().id() == lifecycle_msgs::msg::State::PRIMARY_STATE_ACTIVE) | ||
| return impl_->trigger_transition( | ||
| lifecycle_msgs::msg::Transition::TRANSITION_ACTIVE_ERROR); |
There was a problem hiding this comment.
Suggested change
| lifecycle_msgs::msg::Transition::TRANSITION_ACTIVE_ERROR); | |
| rcl_lifecycle_error_label); |
|
What is the state of this PR? |
|
Will this PR be ever merged? |
|
I think we still need to work on design at 1st, but i don't think i can be working on this in soon. |
|
Given that this PR is so old, and that we need a design fix first, I'm going to close it out. If you are planning on working on it, please push forward on the design update first, then we can open a new PR with changes that implement that design. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (built on top of required PRs ros2/rcl_interfaces#97 and ros2/rcl#618) provides convenience functions for lifecycle nodes to self-trigger the error transitions created in the previous PRs.
This also addresses issue #547