Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for services API to rclcpp #8

Closed
2 tasks done
wjwwood opened this issue Mar 3, 2015 · 0 comments · Fixed by #11
Closed
2 tasks done

Add support for services API to rclcpp #8

wjwwood opened this issue Mar 3, 2015 · 0 comments · Fixed by #11
Assignees

Comments

@wjwwood
Copy link
Member

wjwwood commented Mar 3, 2015

Acceptance Criteria:

  • make the services calls work
  • add an example
@wjwwood wjwwood added the ready Work is about to start (Kanban column) label Mar 3, 2015
@esteve esteve added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed ready Work is about to start (Kanban column) in progress Actively being worked on (Kanban column) labels Mar 6, 2015
@esteve esteve closed this as completed Mar 9, 2015
@esteve esteve removed the in review Waiting for review (Kanban column) label Mar 9, 2015
@esteve esteve reopened this Mar 9, 2015
@esteve esteve added the in review Waiting for review (Kanban column) label Mar 9, 2015
@esteve esteve closed this as completed in #11 Mar 9, 2015
@esteve esteve removed the in review Waiting for review (Kanban column) label Mar 9, 2015
@esteve esteve reopened this Mar 9, 2015
@esteve esteve added the in review Waiting for review (Kanban column) label Mar 9, 2015
@esteve esteve closed this as completed Mar 9, 2015
@esteve esteve removed the in review Waiting for review (Kanban column) label Mar 9, 2015
alsora pushed a commit to alsora/rclcpp that referenced this issue Oct 13, 2020
add timers manager test and bug fixes
clalancette pushed a commit to clalancette/rclcpp that referenced this issue Dec 8, 2021
* Add required conversions to any subscription callback

Signed-off-by: Gonzalo de Pedro <[email protected]>

* Removed extra space

Signed-off-by: Gonzalo de Pedro <[email protected]>
clalancette pushed a commit to clalancette/rclcpp that referenced this issue Dec 21, 2021
* Add required conversions to any subscription callback

* Style fixes for the linters. (ros2#9)

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
* ros2GH-69 Read storage content in a separate thread

For now the publishing starts only after the reading is completly
done. This should change aufter ros2GH-68 is done and a thread-safe
queue can be used instead of std::queue.

* ros2GH-71 Add integration test for timing behavior

* ros2GH-68 Introduce vendor package for shared queue

- Download and install headers from moodycamel readerwriterqueue
- Download and install headers from moodycamel concurrentqueue
- Use readerwriterqueue in code to load and publish concurrently

* ros2GH-71 Retain time difference of messages when playing a bag file

- The main (play) thread sleeps until the time for publishing the
  message is reached.
- Using std::chrono time_point and duration for type-safe time
  arithmetic instead of rcutils time types.

* ros2GH-71 Improve stability of read test

- Subscribers need to maintain a longer history if the messages are
  not consumed fast enough.

* ros2GH-71 Fix Classloader instance lifetime

The Classloader instance needs to outlive all objects created by it.

* ros2GH-71 Extract playing code into a class of its own

Reason: record and play have almost no common code but do the exact
opposite with the storage and rclcpp.

* ros2GH-70 Do not link explicitly against std_msgs

- only required in tests
- this decreases the amount of packages needed for a clean build without tests

* ros2GH-70 Fix error message of storage

* ros2GH-70 Fix pluginlib/storage issue for recording

* ros2GH-71 Cleanup: variable naming

* ros2GH-70 Load storage continuously instead of as fast as possible

- Only load if queue contains less than 1000 messages
- Wait a millisecond before loading again once the queue is long enough

* ros2GH-70 Add options struct to allow specification of queue size

* ros2GH-72 Wait for messages to fill up

* ros2GH-74 Rename integration tests to play/record tests

* ros2GH-74 Use test_msgs in integration tests

- gets rid of string_msgs dependency

* ros2GH-70 Rename is_not_ready to is_pending, use bulk reading to queue

* ros2GH-70 Harmonize storage_loading_future variable

* ros2GH-88 Read messages in order of their timestamps

- Currently, we write sequentially in order of arrival time so
  reading in id order is fine
- This may change at a later time and should not change the reading
  behaviour, i.e. we need to read in order of timestamps

* Fix compiler error on Mac

* ros2GH-8 Fix: use correct ros message type in test

* ros2GH-8 Cleanup: minor code style fixes

* ros2GH-8 Refactor future usage in player

Make the future a class member of player to avoid having to hand it
into several functions which is difficult with a move-only type.

* ros2GH-8 Cleanup: remove verbose logging for every stored message

* ros2GH-8 Refactor rosbag2 interface

Add an explicit overload for record without a topic_names argument to
record all topics.

* fix: call vector.reserve instead of default initalization

* fix record demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants