Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LifecycleNode needs an accessor method for the NodeLogging interface #649

Closed
mjeronimo opened this issue Mar 4, 2019 · 0 comments
Closed

LifecycleNode needs an accessor method for the NodeLogging interface #649

mjeronimo opened this issue Mar 4, 2019 · 0 comments

Comments

@mjeronimo
Copy link
Contributor

Feature request

Feature description

The LifecycleNode class has a member variable, node_logging_, but no accessor method to retrieve it. There are access methods for the other interfaces, but not this one. I am porting the tf2_ros::MessageFilter class to be able to use lifecycle nodes and need the logging interface from the lifecycle node so that I can provide it to the MessageFilter.

Implementation considerations

Could be a simple copy-and-paste of the accessor method from the rclcpp::Node class.
@mjeronimo mjeronimo mentioned this issue Mar 6, 2019
Merged
@mjeronimo mjeronimo mentioned this issue Mar 14, 2019
Closed
@mjeronimo mjeronimo mentioned this issue Aug 9, 2019
Closed
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@brawner
Increase rcl_lifecycle test coverage and add more safety checks (ros2…
7146919 
…#649)

* Increase test coverage and add more safety checks

Signed-off-by: Stephen Brawner <[email protected]>

* More coverage

Signed-off-by: Stephen Brawner <[email protected]>

* Concatenating error messages

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* Forgot a

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* Moving var to top

Signed-off-by: Stephen Brawner <[email protected]>

Co-authored-by: Stephen Brawner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjeronimo