Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non deterministic double free or corruption on ctrl-c #4

Closed
wjwwood opened this issue Sep 4, 2014 · 3 comments
Closed

Non deterministic double free or corruption on ctrl-c #4

wjwwood opened this issue Sep 4, 2014 · 3 comments
Assignees
@dirk-thomas

Comments

@wjwwood
Copy link
Member

wjwwood commented Sep 4, 2014

This has been observed in the talker using opensplice:

$ ./install/bin/talker__ros_middleware_opensplice_cpp
init()
  init() get_instance
create_node()
  create_node() opensplice_static
  create_node() get_instance
  create_node() create_participant in domain 0
  create_node() pass opaque node handle
create_publisher()
create_publisher() opensplice_static
  create_publisher() extract participant from opaque node handle
  create_publisher() invoke register callback
  simple_msgs::type_support::register_type__String()
  create_publisher() create dds publisher
  create_publisher() create topic: chatter
  create_publisher() create data writer
  create_publisher() build opaque publisher handle
Publishing: 'Hello World: 1'
Publishing: 'Hello World: 2'
Publishing: 'Hello World: 3'
^Csignal_handler(2)
*** Error in `./install/bin/talker__ros_middleware_opensplice_cpp': double free or corruption (!prev): 0x00000000016f8ff0 ***
@wjwwood wjwwood added the bug label Sep 4, 2014
@dirk-thomas
Copy link
Member

Happens for me for the OpenSplice publisher as well as the subscriber.

@wjwwood wjwwood added backlog ready Work is about to start (Kanban column) and removed bug Something isn't working ready Work is about to start (Kanban column) labels Feb 24, 2015
@esteve
Copy link
Member

esteve commented Mar 7, 2015

Happens for me too with libopensplice64, but haven't been able to reproduce it with libopensplice63

@dirk-thomas dirk-thomas mentioned this issue Mar 30, 2015
Merged
@dirk-thomas
Copy link
Member

The new unit test added in ros2/examples#7 fails for exactly that reason. Both executables (test_publisher, test_subscriber) return code 134.

@dirk-thomas dirk-thomas added the ready Work is about to start (Kanban column) label Mar 31, 2015
@dirk-thomas dirk-thomas self-assigned this Mar 31, 2015
dirk-thomas added a commit to ros2/rmw_opensplice that referenced this issue Mar 31, 2015
@dirk-thomas
remove dhcpisocpp from LIBRARIES since we can only link against one (…
9ccabcf 
…currently dhcpsacpp) (fix ros2/rclcpp#4)
@dirk-thomas dirk-thomas mentioned this issue Mar 31, 2015
Merged
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed ready Work is about to start (Kanban column) backlog labels Mar 31, 2015
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Apr 1, 2015
nuclearsandwich pushed a commit to ros2/rosidl_typesupport_opensplice that referenced this issue Jun 22, 2018
@dirk-thomas
remove dhcpisocpp from LIBRARIES since we can only link against one (…
3a1328c 
…currently dhcpsacpp) (fix ros2/rclcpp#4)
@charlotteheggem charlotteheggem mentioned this issue May 28, 2020
Closed
alsora pushed a commit to alsora/rclcpp that referenced this issue Oct 12, 2020
Merge pull request ros2#4 from alsora/asoragna/remove-handle
7a5bd1f 
remove unused handle_events() function
@BaiCai1990 BaiCai1990 mentioned this issue Jan 23, 2021
Closed
nuclearsandwich pushed a commit that referenced this issue Mar 5, 2021
Merge pull request #4 from mjeronimo/mjeronimo/add-block-comment
a4f5533 
Address review feedback
clalancette added a commit that referenced this issue Dec 7, 2021
@clalancette
Re-enable most of the rclcpp tests. (#4)
5cf5a7e 
We comment out the ones that are currently giving us trouble.

Signed-off-by: Chris Lalancette <[email protected]>
clalancette added a commit to clalancette/rclcpp that referenced this issue Dec 21, 2021
@clalancette
Re-enable most of the rclcpp tests. (ros2#4)
802ba98 
We comment out the ones that are currently giving us trouble.

Signed-off-by: Chris Lalancette <[email protected]>
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@esteve
Merge pull request ros2#4 from ros2/cpplint
d0083b7 
Fix cpplint warnings
asymingt added a commit to asymingt/rclcpp that referenced this issue Aug 2, 2022
@asymingt
CI nondeterminism test ros2#4
14d853c 
Signed-off-by: Andrew Symington <[email protected]>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
@Martin-Idel-SI @Karsten1987
Allow an arbitrary topic to be recorded (ros2#26)
bdd7fd1 
* ros2GH-52 Extend db schema to include topic meta data

- Two table db layout (messages and topics)
- Messages table references topics table but without foreign key for
  improved write performance
- Create_topic must be called for every topic prior to storing a
  message of this topic.
- Sqlite_storage caches all known topics
- At least for now the type information is stored as a simple string.

* ros2GH-54 Make first rcl subscription prototype work

* ros2GH-54 find type name from topic

* ros2GH-54 Publish messages from database knowing only topic name and pass topic name by terminal

* ros2GH-54 Refactoring of typesupport helpers

* ros2GH-54 Use c++ typesupport

* ros2GH-54 Use cpp typesupport and rclcpp::Node for publisher

* ros2GH-54 Add raw subscription and use in rosbag_record

* ros2GH-54 Add Rosbag2Node and Rosbag2Publisher classes and use them in Rosbag2::play

* ros2GH-54 Rename Rosbag2Publisher to RawPublisher

* ros2GH-54 Minor refactoring of Rosbag2Node

* ros2GH-54 Extract and test waiting for topic into its own method

* ros2GH-54 Fix read integration tests and linters

* ros2GH-55 Refactor Rosbag2Node::create_raw_publisher()

* ros2GH-54 Add subscription method to rosbag node

* ros2GH-54 Keep subscription alive

* ros2GH-54: Extract subscription to correct class

* ros2GH-55 Change interface of raw_publisher to match subscriber

* ros2GH-54 Add test for rosbag node

* ros2GH-54 Unfriend rclcpp class

* ros2GH-54 Make test more robust

* ros2GH-54 Fix build

* ros2GH-54 Minor cleanup and documentation

* ros2GH-55 Minor refactoring + TODO comment

* ros2GH-54 Change dynamic library folder on Windows

* ros2GH-54 Fix build

* ros2GH-54 Add shutdown to test

* ros2GH-55 Add test helpers methods for usage in multiple tests

* ros2GH-55 Add new method to read all topics and types in BaseReadInterface and use it in Rosbag2::play

* ros2GH-55 Fix gcc and msvc

* ros2GH-54 Rename raw to generic in publisher/subscriber

* ros2GH-55 Check that topic and associated type in bag file are well defined before playing back messages

* ros2GH-54 Prevent unnecessary error message loading storage

* ros2GH-54 Fix memory leak

* ros2GH-54 stabilize node test

* ros2GH-55 Check if database exists when opening storage with READ_ONLY flag

* ros2GH-54 Minor cleanup of subscriber

* ros2GH-54 Wait a small amount of time to let node discover other nodes

* Add logging to false case

* ros2GH-54 Catch exceptions and exit cleanly

* Use rmw_serialized_message_t and rcutils_char_array_t consistently

* ros2GH-4 Refactoring for correctness

- pass a few strings as const reference
- throw error when no topics could be found

* Improve error messages when loading plugins

* alphabetical order

* type_id -> type
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
@Karsten1987
writer interface (ros2#205)
dee2f44 
* Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address commments:
- Rewrite history
- Move sequential reader implementation to header/source
- Change namespaces
- Linting

Signed-off-by: Anas Abou Allaban <[email protected]>

* Add visiblity control header

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address structural review feedback

Signed-off-by: Prajakta Gokhale <[email protected]>

* Remove extraneous newline

Signed-off-by: Prajakta Gokhale <[email protected]>

* Add new BaseReaderInterface

* Add new reader interface
* Use the interface in sequential reader

Signed-off-by: Prajakta Gokhale <[email protected]>

* Remove extra newline

Signed-off-by: Prajakta Gokhale <[email protected]>

* Final reader class implementation (ros2#4)

* final reader class

Signed-off-by: Karsten Knese <[email protected]>

* adaptations for rosbag2_transport

Signed-off-by: Karsten Knese <[email protected]>

* address review comments

Signed-off-by: Karsten Knese <[email protected]>

* Make BaseReaderInterface public

Signed-off-by: Prajakta Gokhale <[email protected]>

* Rebase on writer changes

Signed-off-by: Karsten Knese <[email protected]>

* Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address commments:
- Rewrite history
- Move sequential reader implementation to header/source
- Change namespaces
- Linting

Signed-off-by: Anas Abou Allaban <[email protected]>

* Final reader class implementation (ros2#4)

* final reader class

Signed-off-by: Karsten Knese <[email protected]>

* adaptations for rosbag2_transport

Signed-off-by: Karsten Knese <[email protected]>

* address review comments

Signed-off-by: Karsten Knese <[email protected]>

* rebase

Signed-off-by: Karsten Knese <[email protected]>

* structurial changes for rosbag2

Signed-off-by: Karsten Knese <[email protected]>

* rosbag2_transport adaptations

Signed-off-by: Karsten Knese <[email protected]>

* fixes for rebasing

Signed-off-by: Karsten Knese <[email protected]>

* pragma for windows

Signed-off-by: Karsten Knese <[email protected]>

* remove unused file

Signed-off-by: Karsten Knese <[email protected]>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
@Karsten1987
multifile reader (ros2#206)
2f50921 
* Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address commments:
- Rewrite history
- Move sequential reader implementation to header/source
- Change namespaces
- Linting

Signed-off-by: Anas Abou Allaban <[email protected]>

* Add visiblity control header

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address structural review feedback

Signed-off-by: Prajakta Gokhale <[email protected]>

* Remove extraneous newline

Signed-off-by: Prajakta Gokhale <[email protected]>

* Add new BaseReaderInterface

* Add new reader interface
* Use the interface in sequential reader

Signed-off-by: Prajakta Gokhale <[email protected]>

* Remove extra newline

Signed-off-by: Prajakta Gokhale <[email protected]>

* Final reader class implementation (ros2#4)

* final reader class

Signed-off-by: Karsten Knese <[email protected]>

* adaptations for rosbag2_transport

Signed-off-by: Karsten Knese <[email protected]>

* address review comments

Signed-off-by: Karsten Knese <[email protected]>

* Make BaseReaderInterface public

Signed-off-by: Prajakta Gokhale <[email protected]>

* Rebase on writer changes

Signed-off-by: Karsten Knese <[email protected]>

* Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

Introduce new SequentialReader interface

Signed-off-by: Anas Abou Allaban <[email protected]>

* Address commments:
- Rewrite history
- Move sequential reader implementation to header/source
- Change namespaces
- Linting

Signed-off-by: Anas Abou Allaban <[email protected]>

* Final reader class implementation (ros2#4)

* final reader class

Signed-off-by: Karsten Knese <[email protected]>

* adaptations for rosbag2_transport

Signed-off-by: Karsten Knese <[email protected]>

* address review comments

Signed-off-by: Karsten Knese <[email protected]>

* rebase

Signed-off-by: Karsten Knese <[email protected]>

* structurial changes for rosbag2

Signed-off-by: Karsten Knese <[email protected]>

* rosbag2_transport adaptations

Signed-off-by: Karsten Knese <[email protected]>

* fixes for rebasing

Signed-off-by: Karsten Knese <[email protected]>

* pragma for windows

Signed-off-by: Karsten Knese <[email protected]>

* remove unused file

Signed-off-by: Karsten Knese <[email protected]>

* multifile sequential reader

Signed-off-by: Karsten Knese <[email protected]>
ivanpauno pushed a commit to asymingt/rclcpp that referenced this issue Aug 26, 2022
@asymingt @ivanpauno
CI nondeterminism test ros2#4
7a21ff3 
Signed-off-by: Andrew Symington <[email protected]>
ymski pushed a commit to ymski/rclcpp that referenced this issue Sep 22, 2023
@takeshi-iwanari
Merge pull request ros2#4 from tier4/work_for_update_humble_tracepoin…
58a5228 
…t_added

chore: merge from humble 16.0.5
@firesurfer firesurfer mentioned this issue May 15, 2024
Merged
@zxf101826 zxf101826 mentioned this issue Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@esteve @wjwwood @dirk-thomas