Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Decouple rosout publisher init from node init. (#351)… #392

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Revert "Revert "Decouple rosout publisher init from node init. (#351)… #392

wants to merge 4 commits into from
+170 −1

Commits on Oct 31, 2024

  1. Revert "Revert "Decouple rosout publisher init from node init. (ros2#351 

    )" (ros2#352)"

This reverts commit 2648503.

Signed-off-by: Tomoya Fujita <[email protected]>
    @fujitatomoya
    fujitatomoya committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b86a6e2 View commit details
    Browse the repository at this point in the history

  2. Decouple rosout publisher fini from node fini. 

    Signed-off-by: Tomoya Fujita <[email protected]>
    @fujitatomoya
    fujitatomoya committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    383545c View commit details
    Browse the repository at this point in the history

  3. address review comment. 

    Signed-off-by: Tomoya Fujita <[email protected]>
    @fujitatomoya
    fujitatomoya committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    423c851 View commit details
    Browse the repository at this point in the history

  4. fix implicit-function-declaration warning. 

    Signed-off-by: Tomoya Fujita <[email protected]>
    @fujitatomoya
    fujitatomoya committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9af12ed View commit details
    Browse the repository at this point in the history