Use the system version of libyaml when possible #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
That is, don't ask for a very specific version, just any version that is compatible. Signed-off-by: Chris Lalancette <[email protected]>
Now that we are going to use a system version, much of the previous language doesn't apply (and was actually outdated anyway). Update this, and also set the Quality level to 3, which seems to better reflect reality. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/use-system-libyaml
branch
from
d05e75c
to
cf63f94
Compare
|
Rebuild after the latest rebase:
|
|
@clalancette what is the status of this. Is it still needed? |
No, we can close this out since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up not putting any specific requirement here; I only made it look for yaml, and if found, use it. Also, if we don't find it, we actually still download and build version 0.2.5; that just seemed easier since we already know that that works on Windows.
Finally, I updated the quality declarations to better reflect reality. When looking at this in totality, with these changes, I thought it was more appropriate to mark this as quality level 3, rather than the stated 1.
@hidmic @traversaro FYI