Append ros namespace to target container if available. #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change to fix #428.
With this change, when a composable node is loaded into a target container that is running under a
ros_namespace
set using<push_ros_namespace>
, the target container name gets prefixed withros_namespace
using theLaunchContext
. This enables the composable nodes to load into a namespaced target container.How did I test this:
apt install ros-rolling-image-tools
ros2 node list
Without the changes in this PR, the output from the launch would be:
And the composable nodes wouldn't show up with
ros2 node list