Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates legacy launch API tests #167

Merged
merged 17 commits into from
Feb 27, 2019
Merged

Migrates legacy launch API tests #167

merged 17 commits into from
Feb 27, 2019

Commits on Jan 29, 2019

  1. Emits events.ExecutionComplete on Action completion. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    2e954ce View commit details
    Browse the repository at this point in the history

  2. Makes LaunchTestService handle non-process actions. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9398aba View commit details
    Browse the repository at this point in the history

  3. Makes LaunchTestService handle fixture process actions. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b9f3bae View commit details
    Browse the repository at this point in the history

  4. Adds output checks to LaunchTestService. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    f4faf91 View commit details
    Browse the repository at this point in the history

  5. Updates launch_testing package tests. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    78a567d View commit details
    Browse the repository at this point in the history

  6. Applies fixes after launch_testing refactor. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    3a65f65 View commit details
    Browse the repository at this point in the history

  7. Adds OpaqueCoroutine action subclass. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    a1f7fb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: hidmic <[email protected]>
    @wjwwood @hidmic
    wjwwood and hidmic authored Feb 4, 2019
    Configuration menu
    Copy the full SHA
    7a0ac0a View commit details
    Browse the repository at this point in the history

  2. Addresses peer review comments. 

    - Emit ExecutionComplete events on demand.
- Shutdown OpaqueCoroutine gracefully.
- Fix failing test cases.

Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    33d15c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Refactors launch_testing API a bit. 

    To cope with more test cases.

Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    07d55f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Applies style fixes to launch_testing. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    34da363 View commit details
    Browse the repository at this point in the history

  2. Deal with non zero exit on shutdown. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    6d04a9f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Avoids output tests' races. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    aec02bf View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. Applies misc fixes after Windows triaging. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    ea034a2 View commit details
    Browse the repository at this point in the history

  2. Applies more fixes after Windows triaging. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    39f1234 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Fixes linter issue. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    2d9305a View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Addresses peer review comments. 

    - Improved OpaqueCoroutine documentation.
- Added test for launch.event_handlers.OnExecutionComplete.

Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    d05379a View commit details
    Browse the repository at this point in the history