Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[launch] add new Action called IncludeLaunchDescription #115

Closed
wjwwood opened this issue Jul 12, 2018 · 0 comments · Fixed by #120
Closed

[launch] add new Action called IncludeLaunchDescription #115

wjwwood opened this issue Jul 12, 2018 · 0 comments · Fixed by #120
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wjwwood
Copy link
Member

wjwwood commented Jul 12, 2018

Already described in the architecture document:

https://github.com/ros2/launch/blob/88ae20ee2e950df91e5594975a82bffe1ebd928b/launch/doc/source/architecture.rst#basic-actions

Basically it will allow you to include another launch description, which is given to the constructor of the new action. You can already do this by emitting an event, launch.events.IncludeLaunchDescription (https://github.com/ros2/launch/blob/b78d87f31bb995c7226df66826e1a57079ae3a3f/launch/launch/events/include_launch_description.py), so at first this action will be only syntactic sugar but later it should interact with launch arguments (see: #107).

@wjwwood wjwwood added the enhancement New feature or request label Jul 12, 2018
@wjwwood wjwwood added this to the crystal milestone Jul 12, 2018
wjwwood added a commit that referenced this issue Jul 24, 2018
fixes #115

Signed-off-by: William Woodall <[email protected]>
@wjwwood wjwwood self-assigned this Jul 24, 2018
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 24, 2018
wjwwood added a commit that referenced this issue Jul 27, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant