Ensure executor_ is spinning in TransformListener::init #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennischua123
approved these changes
May 23, 2023
franciszhi
force-pushed
the
fc/fix-transform-listener-init
branch
from
d246b27
to
9a09cc3
Compare
franciszhi
force-pushed
the
fc/fix-transform-listener-init
branch
from
9a09cc3
to
44c7942
Compare
franciszhi
changed the title
franciszhi
changed the title
Comment on lines
+214
to
+216
| while (!executor_->is_spinning()) { | ||
| std::this_thread::sleep_for(std::chrono::microseconds(10)); | ||
| } |
There was a problem hiding this comment.
May I ask what actually prompted this change, there's not a related issue nor pull request. Furthermore, when it comes to testing, a frozen node likely would've occured due to incorrect setup in the "main" section of the test file. Is it worth adding a more information needed tag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added tf2_test_transform_listener.transform_listener_spin_thread to test. Without the fix, the newly added test will freeze.