Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle node support for tf2_ros::MessageFilter #95

Open
mjeronimo opened this issue Mar 4, 2019 · 3 comments · May be fixed by #714
Open

Lifecycle node support for tf2_ros::MessageFilter #95

mjeronimo opened this issue Mar 4, 2019 · 3 comments · May be fixed by #714
Labels
backlog enhancement New feature or request

Comments

@mjeronimo
Copy link
Contributor

Feature request

Feature description

Similar to #70 and #94, the MessageFilter class needs support for lifecycle nodes.

Implementation considerations

There could be a constructor that takes the required node interfaces, perhaps in addition to rclcpp::Node and rclcpp_lifecycle::LifecycleNode.
@mjcarroll mjcarroll added enhancement New feature or request backlog labels Mar 14, 2019
@mjeronimo mjeronimo mentioned this issue Mar 14, 2019
Closed
@Karsten1987 Karsten1987 mentioned this issue Apr 16, 2019
Closed
@mjeronimo mjeronimo mentioned this issue Aug 9, 2019
Closed
@kurshakuz
Copy link
Contributor

Are there any updates on that?

@kurshakuz kurshakuz mentioned this issue Sep 19, 2021
Merged
@clalancette
Copy link
Contributor

Are there any updates on that?

Unfortunately not; this is still a backlog/help wanted item. We'd be happy to review contributions that improve it, though.

@rasmusan rasmusan mentioned this issue Jan 24, 2023
Closed
@CursedRock17
Copy link
Contributor

CursedRock17 commented Mar 10, 2024 •
edited
Loading

According to this table this issue was solved with issue #96. I don't think that's entirely true, can I pick this up?

@CursedRock17 CursedRock17 mentioned this issue Mar 15, 2024
Closed
@CursedRock17 CursedRock17 linked a pull request Oct 12, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@clalancette @mjcarroll @mjeronimo @kurshakuz @CursedRock17