Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Transform Publisher should use node interfaces #103

Closed
Karsten1987 opened this issue Apr 16, 2019 · 0 comments · Fixed by #104
Closed

Static Transform Publisher should use node interfaces #103

Karsten1987 opened this issue Apr 16, 2019 · 0 comments · Fixed by #104
Assignees

Comments

@Karsten1987
Copy link
Contributor

Karsten1987 commented Apr 16, 2019

Currently the static transform publisher requires a shared pointer to a complete node in order to create the publisher. This means, that as-is, this TF publisher can't be easily used in a composable node constructor, essentially because a shared pointer to this can't be created when the object itself is not fully created.

The feature request here is to use the NodeTopicsInterface instead and call create publisher on this instead of the full node instance.
See here:
https://github.com/ros2/rclcpp/blob/master/rclcpp/include/rclcpp/create_publisher.hpp#L28-L47

This will also ease up the tickets regarding the lifecycle nodes #94 and #95 as they also provide the node topic interface.

Similar work is started in here: #100

@Karsten1987 Karsten1987 self-assigned this Apr 16, 2019
@Karsten1987 Karsten1987 added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 17, 2019
@Karsten1987 Karsten1987 removed the in review Waiting for review (Kanban column) label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant