Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Launch XML Schema #317

Closed
rob-clarke opened this issue Jun 24, 2021 · 3 comments · Fixed by #318
Closed

Update Launch XML Schema #317

rob-clarke opened this issue Jun 24, 2021 · 3 comments · Fixed by #318
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rob-clarke
Copy link

Similar to #285 I believe the schema doesn't match the current implementation.

In the schema, the <node> element currently defines a ns attribute but this appears to have been renamed to namespace. At least if here is where it is being parsed.

@ivanpauno Mentioning you as it's similar to the other issue you dealt with.
@rob-clarke rob-clarke mentioned this issue Jun 24, 2021
Closed
@ivanpauno ivanpauno added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 29, 2021
@ivanpauno
Copy link
Member

@rob-clarke you're correct, the correct attribute is namespace and not ns.
A PR is welcomed.

defines a ns attribute but this appears to have been renamed to namespace

The attribut has always been namespace, but it was wrongly documented as ns in the schema.

@christophebedard
Copy link
Member

I can take care of this (if @rob-clarke isn't already on it) and also add ros_args (ros2/launch_ros#253) at the same time

@christophebedard christophebedard mentioned this issue Jun 30, 2021
Merged
@christophebedard
Copy link
Member

I can take care of this (if @rob-clarke isn't already on it) and also add ros_args (ros2/launch_ros#253) at the same time

I just went ahead and did it: #318

@rob-clarke rob-clarke mentioned this issue Jul 5, 2021
Merged
clalancette pushed a commit to ros2/ros2_documentation that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
fb3a919 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317
mergify bot pushed a commit to ros2/ros2_documentation that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
b116a33 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)
mergify bot pushed a commit to ros2/ros2_documentation that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
534dca5 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)
clalancette pushed a commit to ros2/ros2_documentation that referenced this issue Jul 6, 2021
@mergify @rob-clarke
Update Launch-files-migration-guide.rst (#1719) (#1724)
6e1ae94 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)

Co-authored-by: rob-clarke <[email protected]>
clalancette pushed a commit to ros2/ros2_documentation that referenced this issue Jul 6, 2021
@mergify @rob-clarke
Update Launch-files-migration-guide.rst (#1719) (#1725)
2038a7b 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)

Co-authored-by: rob-clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@christophebedard @ivanpauno @rob-clarke