Use wait_for_service in parameter demos #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
approved these changes
Aug 11, 2017
There was a problem hiding this comment.
lgtm once CI green.
Note: this depends on ros2/rclcpp#356 and the referenced ci use both changes
dirk-thomas
reviewed
Aug 11, 2017
| @@ -27,7 +29,15 @@ int main(int argc, char ** argv) | |||
| auto parameter_service = std::make_shared<rclcpp::parameter_service::ParameterService>(node); | |||
|
|
|||
| auto parameters_client = std::make_shared<rclcpp::parameter_client::SyncParametersClient>(node); | |||
| while (!parameters_client->wait_for_service(1s)) { | |||
| if (!rclcpp::ok()) { | |||
| std::cout << "Interrupted while waiting for the service. Exiting." << std::endl; | |||
There was a problem hiding this comment.
This entire file uses streams. If changing to printf, all prints should be updated. This can be done either here or in a separate PR
There was a problem hiding this comment.
I am not saying that the existing cout's need to be updated in this PR (though since it would only take a couple of minutes I think it would be good to do).
But newly added code should not use it.
dirk-thomas
reviewed
Aug 11, 2017
|
|
||
| // Setup callback for changes to parameters. | ||
| auto sub = parameters_client->on_parameter_event(on_parameter_event); | ||
|
|
||
| rclcpp::spin(node); | ||
|
|
||
| rclcpp::shutdown(); |
There was a problem hiding this comment.
Should the other executables also call shutdown?
dirk-thomas
approved these changes
Aug 11, 2017
There was a problem hiding this comment.
LGTM (with style checks passing and conflicts between #162 resolved)
dhood
added
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to ros2/rclcpp#356
fixes test flakiness listed in ros2/build_farmer#41