Skip to content

Commit

Permalink
Address peer review comments.
Browse files Browse the repository at this point in the history
Signed-off-by: Michel Hidalgo <[email protected]>
  • Loading branch information
hidmic committed Apr 29, 2019
1 parent 02d08b9 commit 044d5fb
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions demo_nodes_cpp/test/test_executables_tutorial.py.in
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ from launch.actions import OpaqueFunction

import launch_testing
import launch_testing.asserts
import launch_testing.utils
import launch_testing_ros


Expand All @@ -26,6 +27,7 @@ def generate_test_description(ready_fn):
]
for process in processes_under_test:
launch_description.add_action(process)
launch_description.add_action(launch_testing.utils.KeepAliveProc())
launch_description.add_action(
OpaqueFunction(function=lambda context: ready_fn())
)
Expand Down Expand Up @@ -65,8 +67,8 @@ class TestExecutablesTutorialAfterShutdown(unittest.TestCase):
# shutdown test termination is delayed instead, the testing
# framework complains about the launch run terminating before
# tests are done.
#
# launch_testing.asserts.assertExitCodes(
# proc_info,
# process=processes_under_test[-1]
# )

launch_testing.asserts.assertExitCodes(
proc_info,
process=processes_under_test[-1]
)

0 comments on commit 044d5fb

Please sign in to comment.