Set the nightly clang build to run the libcxx mixin #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <[email protected]>
|
@emersonknapp is this ready for review and an initial build attempt of ros2/rmw_fastrtps#259? |
|
Yes! :) |
3 tasks
|
This just builds up to and tests rmw_fastrtps_cpp for now. If that passes we'll try a full build on the same parameters. |
nuclearsandwich
added
in review
|
This is a full build and test with the clang-libcxx work: There are more failures than present in the most recent current clang nightly but the failures present in that nightly are not present in the libcxx build 🙃 |
nuclearsandwich
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emerson Knapp [email protected]
Related to ros2/ros2#664
@nuclearsandwich i think this is all that is needed to get the nightly running TSA