restrict boost dependencies to the ones used #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
requested changes
Feb 24, 2020
scripts/install_debs_cmake.sh
Outdated
| @@ -24,7 +24,7 @@ sudo apt-get install -y \ | |||
| g++ \ | |||
| git \ | |||
| google-mock \ | |||
| libboost-all-dev \ | |||
| libboost-iostreams-dev \ | |||
There was a problem hiding this comment.
This is really a minor point, but I'd rather not make changes to this file. The simple reason is that right now, the only changes that we have to this repository compared to upstream are in the package.xml, and I'd like to keep it that way. Anyone building from-source can probably afford to install the all-dev.
There was a problem hiding this comment.
fair enough, reverted in 2dc82c5
Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jun 17, 2020
* restrict boost dependencies to the ones used Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jun 18, 2020
* restrict boost dependencies to the ones used Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Jul 23, 2020
* restrict boost dependencies to the ones used Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Sep 24, 2020
* restrict boost dependencies to the ones used Signed-off-by: Mikael Arguedas <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Oct 23, 2020
* restrict boost dependencies to the ones used Signed-off-by: Mikael Arguedas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of https://discourse.ros.org/t/generating-dev-and-runtime-artefacts-from-ros-packages/12448 and removing the use of the blanket
boostrosdep key as a dependency.Signed-off-by: Mikael Arguedas [email protected]