Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about calling conventions #99

Merged

Conversation

hoffmann-stefan
Copy link
Member

@hoffmann-stefan hoffmann-stefan commented Apr 22, 2023

extracted from #94

This fixes all colcon build warnings for foxi on linux.
There are some new ones for humbe, but they will be fixed seperatly.

In file included from /home/stefan/public_git/ros2_dotnet_ws/build/unique_identifier_msgs/rosidl_generator_dotnet/unique_identifier_msgs/msg/uuid.c:20:
/home/stefan/public_git/ros2_dotnet_ws/build/unique_identifier_msgs/rosidl_generator_dotnet/unique_identifier_msgs/msg/rcldotnet_uuid.h:27:1: warning: ‘cdecl’ attribute ignored [-Wattributes]
   27 | const void * RCLDOTNET_UNIQUE_IDENTIFIER_MSGS_UNIQUE_IDENTIFIER_MSGS_MSG_UUID_CDECL unique_identifier_msgs__msg__UUID__get_typesupport();
      | ^~~~~

From the commit message:

This removes a warning when compiling on x64 plattforms.
The C# DllImportAttribute ignores this calling canvention as well, but dosn't give a warning.

@esteve esteve deleted the branch ros2-dotnet:main May 2, 2023 13:25
@esteve esteve closed this May 2, 2023
@hoffmann-stefan hoffmann-stefan changed the base branch from master to main May 2, 2023 17:11
This removes a warning when compiling on x64 plattforms.
The C# DllImportAttribute ignores this calling canvention as well, but dosn't give a warning.
@hoffmann-stefan hoffmann-stefan merged commit 070f6a9 into ros2-dotnet:main May 15, 2023
@hoffmann-stefan hoffmann-stefan deleted the feature/cdecl-warning branch May 15, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants