Use CamlCase for Property names, add support for default values #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffmann-stefan
added a commit
to schiller-de/tf2_dotnet
that referenced
this pull request
Sep 7, 2022
hoffmann-stefan
force-pushed
the
idl-defaults-and-naming
branch
from
6d3790b
to
d125165
Compare
hoffmann-stefan
force-pushed
the
idl-defaults-and-naming
branch
from
d125165
to
ff38e4b
Compare
|
Merging this togeter with #90 as both significantly break the API of this library. Users can update this now in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small PR that implements #91.
I chose CamelCase as there is currently the most preferred alternative in that issue (though there are not many votes).
Additionally added support for default values in ros interfaces, but if you like I could extract them to a separate PR.
If we want't to make the old names still work but obsolete we can use something like this: https://gist.github.com/hoffmann-stefan/0aa0809ac0b511e837ca761a438b044a