Ported to ROS2 Dashing #210
Conversation
- Moved contents from "src/xacro/" folder to "xacro/" folder. - Renamed scripts folder to resource folder. - Modifed package.xml and setup.py according to ROS2 rules. - Deleted CMakeLists.txt
- Modified all python scripts as per ros2 coding guidelines. - Added substitution_args.py file, replacement for roslaunch's resolve_args() method, as it is not available in ROS2's ros2launch package. - Updated shebang line in all python scripts to use python3. - Resolved errors where some test cases were failing to find out some .xml files. (eg. include1.xml) - Added temporary workaround for rosgraph.names.load_mappings because rosgraph is not migrated to ROS2.
…, required for ament_copyright rule.
…test this package on bouncy.
- Added some more details in README.md file.
|
@kazuki0824, could you please describe in which respect this is different to #203? |
|
@rhaschke Completely the same for now. This is currently still in progress and set as draft. Further changes are yet to be pushed. |
|
So, I guess this is simply a rebase of #203 to the latest master so far? |
|
@rhaschke Yes, it is. |
|
@kazuki0824 What's the status of this PR? Do you need help with anything? |
|
@kazuki0824 It seems like there is some unfinished work with Please let me know! |
|
FWIW, I briefly messed around to get find substitution working using ament_index_python: https://github.com/jacobperron/xacro/commit/837e862979616c655d60b57ec24e80d668b00d2b |
|
@jacobperron I looked through the commit(https://github.com/jacobperron/xacro/commit/837e862979616c655d60b57ec24e80d668b00d2b). Your substitution_args.py looks great to me. I would like you to send PR to my project. Thank you. |
|
@kazuki0824 Can we get that merged in? |
|
Changes on #211 |
Same as the title. This PR is based on @vandanamandlik 's #203. Thanks very much.