Ros2 devel #200
Closed
Ros2 devel #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed run_depend tag to exec_depend as per ROS2 rules. - Added new tag build_type with value ament_python. - Renamed roslaunch package name to ros2launch.
Added data_files configuration settings. Modified entry_points setttings.
…osgraph is not migrated to ROS2.
…xml files. (eg. include1.xml)
removed unnecessary code from setup.py and some cosmetic changes as per ros2 guidelines.
Modified all python scripts as per ros2 coding guidelines. Added substitution_args.py file, replacement for roslaunch's resolve_args() method, as it is not available in ROS2's ros2launch package.
Changed license from BSD to 'Apache License, Version 2.0'.(As per ROS2 rules.) Modified code according to linter test rules eg. - Unnecessary dict call - rewrite as a literal - Indentation error - Remove bad quotes
…, required for ament_copyright rule.
As per ROS2 Migration guide If the ROS 1 package uses CMake only to invoke the setup.py file and does not contain anything beside Python code (e.g. also no messages, services, etc.) it should be converted into a pure Python package in ROS 2. so removed the CMakeLists.txt file. Referred link: https://index.ros.org/doc/ros2/Migration-Guide/
- A001 "input" is a python builtin and is being shadowed, consider renaming the variable. - A002 "str" is used as an argument and thus shadows a python builtin, consider renaming the argument. - A003 "next" is a python builtin, consider renaming the class attribute.
- Remove bad quotes
- Remove bad quotes from multiline string
- line break before binary operator
- line break after binary operator
- invalid escape sequence '\('
Added shebang line in test_copyright.py, test_flake8.py and test_pep257.py scripts to use python3.
|
Could you please cleanup and squash your commits into meaningful units? |
|
Hi, I did cleanup and checked in on ros2 branch ( created new branch). |
|
Just linking the new PR for everyone who arrives here: #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xacro porting to ROS2.