Link Visual and Collision are not exported to XML #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Jul 11, 2023
* add test to build robot model from python urdf classes * add more tests on python urdf build * update backward compatibility Link(visual=...) does not set <visual> on <link> since 0.4.0, breaks backward compatibility * Robot accepts version kwarg Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
The Visual class does not have an attribute name anymore. Consequently, we can not expect the test to work.
I did not find a way to change the branch from which the changes are pulled from. (Unless opening a new PR) Thus, I repurposed the |
clalancette
requested changes
Aug 9, 2023
The attributes 'visual' and 'collision' exist only for back-compability reasons and shall only be used if there exists one and only one visual or collision element. For links with multiple visual or collision elements the new method is added which shall be used. This simplifies the usage of the API.
- In the previous version, collision and visual objects were added twice. Tests were updated accordingly. - Added tests to check if visual and collision objects can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized, that Visual and Collision are not exported to XML, if they are set via the Constructor.
There is also an open issue for it #42.
In addition, I realized that this issue was already fixed on the melodic-branch, see pull request #47.
Consequently, I cherry-pick the changes introduced with #47. In addition, I had to remove one test, since the
Visualclass does not have an attributenameanymore.Closes: #42
Relates: #47