vision_opencv_python3: 1.13.1-1 in 'melodic/distribution.yaml' [bloom]

[k-okada]

Increasing version of package(s) in repository vision_opencv_python3 to 1.13.1-1:

• upstream repository: https://github.com/jsk-ros-pkg/vision_opencv_python3.git
• release repository: https://github.com/tork-a/vision_opencv_python3-release.git
• distro file: melodic/distribution.yaml
• bloom version: 0.10.7
• previous version for package: null

cv_bridge_python3

* depends on python3, change package name to cv_bridge_python3
* Contributors: Kei Okada

[k-okada]

this PR release cv_bridge linked against boost/python3, which enable melodic users to use python3 code with catkin_virtualenv environment.
The generate deb installs following files

/.
/opt
/opt/ros
/opt/ros/melodic
/opt/ros/melodic/lib
/opt/ros/melodic/lib/pkgconfig
/opt/ros/melodic/lib/pkgconfig/cv_bridge_python3.pc
/opt/ros/melodic/lib/python3
/opt/ros/melodic/lib/python3/dist-packages
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/__init__.py
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/__pycache__
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/__pycache__/__init__.cpython-36.pyc
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/__pycache__/core.cpython-36.pyc
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/boost
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/boost/__init__.py
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/boost/cv_bridge_boost.so
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge/core.py
/opt/ros/melodic/lib/python3/dist-packages/cv_bridge_python3-1.13.0.egg-info
/opt/ros/melodic/share
/opt/ros/melodic/share/cv_bridge_python3
/opt/ros/melodic/share/cv_bridge_python3/cmake
/opt/ros/melodic/share/cv_bridge_python3/cmake/cv_bridge_python3Config-version.cmake
/opt/ros/melodic/share/cv_bridge_python3/cmake/cv_bridge_python3Config.cmake
/opt/ros/melodic/share/cv_bridge_python3/package.xml
/usr
/usr/share
/usr/share/doc
/usr/share/doc/ros-melodic-cv-bridge-python3
/usr/share/doc/ros-melodic-cv-bridge-python3/changelog.Debian.gz

to use this code, we need to add following code to your python3 code.

import sys, os; sys.path.insert(0,'/opt/ros/' +  os.environ['ROS_DISTRO'] + '/lib/python3/dist-packages/')
import cv_bridge
from cv_bridge.boost.cv_bridge_boost import getCvType

see jsk-ros-pkg/jsk_recognition#2668 (comment) for working example

[ivanpauno]

LGTM!

[ivanpauno]

it would be good to add a top level license file

[ivanpauno]

this PR release cv_bridge linked against boost/python3,

does this cause any issue if you also have cv_bridge installed?

[k-okada]

@ivanpauno thanks for comment

I haven't seen any problem by installing both cv_bridge and cv_bridge_python3

k-okada@p51s:/tmp$ sudo apt-get install ros-melodic-cv-bridge
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  ros-melodic-cv-bridge
0 upgraded, 1 newly installed, 0 to remove and 583 not upgraded.
Need to get 0 B/90.0 kB of archives.
After this operation, 352 kB of additional disk space will be used.
Selecting previously unselected package ros-melodic-cv-bridge.
(Reading database ... 692209 files and directories currently installed.)
Preparing to unpack .../ros-melodic-cv-bridge_1.13.0-0bionic.20220127.152918_amd64.deb ...
Unpacking ros-melodic-cv-bridge (1.13.0-0bionic.20220127.152918) ...
Setting up ros-melodic-cv-bridge (1.13.0-0bionic.20220127.152918) ...
k-okada@p51s:/tmp$ sudo dpkg -i ros-melodic-cv-bridge-python3_1.13.1-1bionic_amd64.deb
(Reading database ... 692231 files and directories currently installed.)
Preparing to unpack ros-melodic-cv-bridge-python3_1.13.1-1bionic_amd64.deb ...
Unpacking ros-melodic-cv-bridge-python3 (1.13.1-1bionic) over (1.13.0-1bionic) ...
Setting up ros-melodic-cv-bridge-python3 (1.13.1-1bionic) ...

[ivanpauno]

I haven't seen any problem by installing both cv_bridge and cv_bridge_python3

I don't mean only installing, do packages using the original cv_bridge continue working correctly?

[k-okada]

I don't mean only installing, do packages using the original cv_bridge continue working correctly?

Sure cv_bridge_pytho3 installs under

/opt/ros/melodic/lib/python3/dist-packages/cv_bridge

and default melodic/setup.sh only points to /opt/ros/melodic/lib/python2.7/dist-packages, so it will not conflict on default settings,

https://github.com/ros/catkin/blob/bf5d8170cd6dca5341e94d932d568a98f7a779fc/python/catkin/builder.py#L291-L303

As I wrote #32505 (comment), we need to set

import sys, os; sys.path.insert(0,'/opt/ros/' +  os.environ['ROS_DISTRO'] + '/lib/python3/dist-packages/')

to use this pacakge.

[hidmic]

this PR release cv_bridge linked against boost/python3, which enable melodic users to use python3 code with catkin_virtualenv environment.

@k-okada hmm this is fairly unusual, particularly for an aging ROS distribution that only supports Python 2.x. @clalancette thoughts?

[clalancette]

@k-okada hmm this is fairly unusual, particularly for an aging ROS distribution that only supports Python 2.x. @clalancette thoughts?

It is unusual, but I know that there are people using Melodic with Python 3. As long as it doesn't collide with the original vision_opencv either at build-time or at run-time, I'm fine with taking this.

[ivanpauno]

Thanks for the answer @k-okada !
If you can address #32505 (comment) then this is ready to merge.

[k-okada]

ok, done jsk-ros-pkg/vision_opencv_python3#1