Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py_trees_msgs: 0.3.6-1 in 'noetic/distribution.yaml' [bloom] #25857

Merged
merged 1 commit into from
Jul 21, 2020
Merged

py_trees_msgs: 0.3.6-1 in 'noetic/distribution.yaml' [bloom] #25857

merged 1 commit into from
Jul 21, 2020

Conversation

stonier
Copy link
Contributor

@stonier stonier commented Jul 19, 2020

Increasing version of package(s) in repository py_trees_msgs to 0.3.6-1:

@stonier stonier requested a review from sloretz as a code owner July 19, 2020 22:18
clalancette
clalancette reviewed Jul 21, 2020
View reviewed changes
noetic/distribution.yaml
py_trees_msgs:
doc:
type: git
url: https://github.com/splintered-reality/py_trees_msgs.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stonier It looks like previous releases of this package were done from the stonier github organization. This one looks to be released from splintered-reality. That's totally fine, but should we update the older versions (in Melodic) to point to the splintered-reality organization instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about that, but should be fine with github redirects right?

sloretz
sloretz approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for Noetic, merging without resolving what to do about melodic distribution.yaml

@sloretz sloretz merged commit 8688923 into ros:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stonier @clalancette @sloretz