Replaced zero with NULL for null pointer constants #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the improvement. |
|
@dirk-thomas: would this PR be considered for a backport to |
|
I don't think that addressing compiler warnings is important enough to backport. If you would like to create a PR for it I can certainly merge it. |
gavanderhoorn
added a commit
to gavanderhoorn/ros_comm
that referenced
this pull request
Jun 18, 2019
But use `NULL`, which will evaluate to `nullptr` on platforms where appropriate and `0` elsewhere. Identical to ros/rosconsole#14.
|
See: ros/ros_comm#1730. |
dirk-thomas
pushed a commit
to ros/ros_comm
that referenced
this pull request
Oct 3, 2019
But use `NULL`, which will evaluate to `nullptr` on platforms where appropriate and `0` elsewhere. Identical to ros/rosconsole#14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ROS_INFO, ROS_WARN and ROS_ERROR the warning -Wzero-as-null-pointer-constant is triggered in code that is compiled with c++11.
As of gcc 4.7 and clang 5.0 the compiler will trigger a warning if 0 is used instead of nullptr in c++11.
Replaced 0 with NULL to be compatible c++11+ and prior versions.