Bump CMake version to avoid CMP0048 warning #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
|
Waiting for Noetic PR to be passing... |
|
@ros-pull-request-builder retest this please |
|
While the Noetic CI is still red the patch addresses the CMake warnings compared to the state on the target branch: http://build.ros.org/view/Ndev/job/Ndev__ros_comm__ubuntu_focal_amd64/20/ (same number of compiler warnings). |
stonier
added a commit
to splintered-reality/py_trees
that referenced
this pull request
Aug 3, 2020
This is the officially supported version and eliminates
a CMP0048 warning on focal. See also
ros/ros_comm#1869
stonier
added a commit
to splintered-reality/py_trees_ros
that referenced
this pull request
Aug 3, 2020
This is the officially supported version and eliminates
a CMP0048 warning on focal. See also
ros/ros_comm#1869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building this package in Debian Buster and Ubuntu Focal.
Same as ros/catkin#1052