Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include order for cpplint #186

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix include order for cpplint #186

merged 2 commits into from
Jan 12, 2022

Conversation

jacobperron
Copy link
Contributor

@jacobperron
Use double-quotes for other includes
b4d6088 
This is backwards compatible with older versions of cpplint.

Signed-off-by: Jacob Perron <[email protected]>
clalancette
clalancette approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@jacobperron jacobperron mentioned this pull request Jan 11, 2022
Merged
@jacobperron jacobperron merged commit 9b6f910 into ros2 Jan 12, 2022
@jacobperron jacobperron deleted the jacob/update_cpplint_fork branch January 12, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @clalancette