Bump CMake version to avoid CMP0048 warning #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
sloretz
approved these changes
Apr 1, 2020
|
@nuclearsandwich mind taking a look at this one? I think you might be the maintainer of this repo. |
I may have forgotten but I can't deny the possibility. I'll take a look. |
nuclearsandwich
approved these changes
Apr 3, 2020
|
@ahcorde you can merge this or I'll do it when I make the next metapackages release. I'm working on a rosdep release today. |
|
feel free to merge it when you are ready to release the next metapackages release. |
|
@nuclearsandwich @ahcorde I'm clicking merge to remove this PR from my list; hope you don't mind :) |
Not at all. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.
ros/catkin#1052
Signed-off-by: ahcorde [email protected]