Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if tf is just a slash "/" resolve should not append "/" #234

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

renan028
Copy link

No description provided.

@tfoote
Copy link
Member

tfoote commented Aug 17, 2023

Can you clarify what use case this is effecting? And why you believe that this is the right behavior?

@renan028
Copy link
Author

Can you clarify what use case this is effecting? And why you believe that this is the right behavior?

If the tf_prefix == / and frame == base_link, for instance, I would expect resolve(prefix, frame) to return base_link, but it returns /base_link instead.
Example: https://godbolt.org/z/vzs8x7e7e
This has more than one year, thus I don't remember exact packages, but there are some gazebo packages that expects that (passing tf_prefix as a slash /)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants