Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testsuite #27

Merged
merged 10 commits into from
Jun 11, 2014
Merged

Added testsuite #27

merged 10 commits into from
Jun 11, 2014

Conversation

esteve
Copy link
Member

@esteve esteve commented May 29, 2014

This branch reenables tests and updates the testsuite to be compiled on Hydro and onwards.

@esteve esteve closed this May 29, 2014
@esteve
Copy link
Member Author

esteve commented May 29, 2014

Tests compile but are never run from rostest, closing to address it. Will reopen once the tests actually run.

esteve and others added 2 commits June 6, 2014 18:35
…o support calling generate_dynamic_reconfigure_options from dynamic_reconfigure's source.
@esteve esteve reopened this Jun 6, 2014
@esteve
Copy link
Member Author

esteve commented Jun 6, 2014

This branch now contains a simple test that runs with catkin_make run_tests. It also checks for issue #6

catkin_package(LIBRARIES dynamic_reconfigure_config_init_mutex
INCLUDE_DIRS include
CATKIN_DEPENDS message_runtime std_msgs
CFG_EXTRAS extras.cmake
CFG_EXTRAS dynamic_reconfigure-macros.cmake dynamic_reconfigure-extras.cmake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should only need dynamic_reconfigure-extras.cmake.em since that already includes the other file.

@esteve
Copy link
Member Author

esteve commented Jun 9, 2014

@dirk-thomas I removed the extra cmake module. I had to add roscpp_LIBRARIES explicitly to make this work on Hydro, which I don't really understand why. Shouldn't catkin_LIBRARIES contain roscpp_serialization and roscpp after find_package(catkin ...)?

…est server. Added a one second delay to make sure that the configuration changes are committed on the server
@dirk-thomas
Copy link
Member

The find_package(rostest) line is resetting your catkin variables. You need the newer version of catkin (ros/catkin#629) which is currently scheduled to be released into Hydro (ros/rosdistro#4609). Therefore you might also want to add a version dependency on catkin 0.5.87.

@esteve
Copy link
Member Author

esteve commented Jun 10, 2014

@dirk-thomas Thanks, just updated package.xml and CMakeLists.txt. Is that version of catkin getting backported to Groovy as well?

@dirk-thomas
Copy link
Member

Yes

@esteve esteve changed the title Reenable tests Added testsuite Jun 11, 2014
esteve added a commit that referenced this pull request Jun 11, 2014
@esteve esteve merged commit 7e38c59 into master Jun 11, 2014
@esteve esteve deleted the enable-tests branch June 11, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants