Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation problems with deprecated macros #31

Merged
merged 4 commits into from
Jan 28, 2016
Merged

Fix compilation problems with deprecated macros #31

merged 4 commits into from
Jan 28, 2016

Conversation

j-rivero
Copy link
Contributor

Workaround for issue #30.

Basically the solution is in commit f3f2d90: duplicate the log function with a new name, mark it as deprecated and use it in the deprectated macros. I've leaved the deprecation warning on the console_bridge own code so we remember to remove it in the next releases.

I've implemented a basic test which just pretend to compile and helped to simulate downstream code. I've also enable the test in travis.

This is a Workaround for issue #30, basically duplicate
the log function with a new name, mark it as deprecated
and use it in the deprectated macros.
@scpeters
Copy link
Contributor

Actually that console_bridge_deprecated() statement is making travis fail since it has -Werror set.

@j-rivero
Copy link
Contributor Author

Actually that console_bridge_deprecated() statement is making travis fail since it has -Werror set.

No problem, removed.

@jspricke can you confirm that the fix works for you?

@scpeters
Copy link
Contributor

+1

waiting for confirmation from @jspricke

@jspricke
Copy link
Member

I've tested this patch on top of the console_bridge 0.3-3 currently in Debian unstable and compilation of ros-comm and a few others worked fine.

I'm fine with the patch, except, that I would vote against including gtest in here, but rather depend on it.

@scpeters
Copy link
Contributor

@j-rivero have we ever tried using find_package to find libgtest-dev?

@jspricke
Copy link
Member

@scpeters
Copy link
Contributor

How do you find the gtest source on osx? I don't know of a homebrew formula that installs the gtest source

@jspricke
Copy link
Member

No idea, I don't use Apple. But I guess you can just put the sources somewhere and point cmake to it.

@scpeters
Copy link
Contributor

I just posted a question on the homebrew mailing list:

@scpeters
Copy link
Contributor

Embedding gtest seems to be the best cross-platform way to use it, so I'm going to merge this as-is.

scpeters added a commit that referenced this pull request Jan 28, 2016
Fix compilation problems with deprecated macros
@scpeters scpeters merged commit 88a27e7 into ros:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants