Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoadMap service #95

Closed
wants to merge 1 commit into from
Closed

Conversation

jacobperron
Copy link

The service is for loading a map as an nav_msgs/OccupancyGrid given a resource ID. It also features a result member to encode errors. I tried to make the result codes generic enough for support of arbitrary backends and underlying data structures.

This could be implemented in a map_loader node or directly in map_server seeing how it already "loads" a map on startup.

@jacobperron
Copy link
Author

Attempt to resolve #94

@tfoote
Copy link
Member

tfoote commented Nov 3, 2016

Thanks for submitting this. It's updated the service to use a string id instead of a path. And having the result codes is a good addition. However it needs a very clear semantic of how to resolve the resource id such that alternative implementations would behave similarly.

@jack-oquin
Copy link
Member

Making it a string requires clearly defining the semantics. The obvious choice is a URL, with at least these options provided:

  • file:///path/to/local/file.yaml
  • package://our_maps_package/maps/floor3.yaml

Other nice-to-have schemes could include http:, https:, and remote file:.

@doisyg
Copy link

doisyg commented Nov 25, 2019

Can we merge this? This is blocking for : ros-planning/navigation#461

@jacobperron
Copy link
Author

Since I've lost access to the origin repository, I've opened a continuation PR #152. I've made changes there to switch to URL semantics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants