Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #839: Adding disabled tests to catkin_test_results summary. #840

Closed
wants to merge 1 commit into from
Closed

Fixes #839: Adding disabled tests to catkin_test_results summary. #840

wants to merge 1 commit into from

Conversation

rsinnet
Copy link

@rsinnet rsinnet commented Dec 23, 2016

I set it to read from both disabled (gtest) and skipattributes. I myself haven't seen skip but it appeared in the ament commit: ament/ament_tools@0c6003b.

@rsinnet
Copy link
Author

rsinnet commented Dec 23, 2016

Closing and reopening, deleted two debug print statements that I added and want to rerun tests.

@rsinnet rsinnet closed this Dec 23, 2016
@rsinnet rsinnet reopened this Dec 23, 2016
@dirk-thomas
Copy link
Member

dirk-thomas commented Jan 26, 2017

@rsinnet Thank you for the contribution. I have created a new PR #848 against the kinetic-devel branch (while maintaining your authorship of the commit). Since all these Python function are potentially being used by other code changing their return values to include the skipped tests would break existing code. Therefore I have created new functions (with the suffix 2) which provide the skipped tests while maintaining the existing API. It would be great if you could test the referenced PR and confirm if it works for you.

@rsinnet
Copy link
Author

rsinnet commented Feb 2, 2017

Closing this since it has been merged via PR #848.

@rsinnet rsinnet closed this Feb 2, 2017
@rsinnet rsinnet deleted the indigo-devel branch March 5, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants