Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump CMake minimum version to use new behavior of CMP0048 #1052

Merged
merged 2 commits into from
Jan 22, 2020
Merged

bump CMake minimum version to use new behavior of CMP0048 #1052

merged 2 commits into from
Jan 22, 2020

Commits on Jan 22, 2020

  1. Use CMP0048 New behavior 

    CMP0048 NEW behavior sets PROJECT_VERSION variables to empty strings if
project() is called with no VERSION argument. This could be a problem
for packages that set VERSION variables prior to project() because
project() would then clear them, but catkin does not do this.

Signed-off-by: Shane Loretz <[email protected]>
    @sloretz
    sloretz committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    030ec88 View commit details
    Browse the repository at this point in the history

  2. try raising the minimum CMake version instead

    @dirk-thomas
    dirk-thomas committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    9306119 View commit details
    Browse the repository at this point in the history