Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipped / disabled tests to catkin_test_results summary #848

Merged
merged 2 commits into from
Jan 30, 2017

Conversation

dirk-thomas
Copy link
Member

Replaces #840.

@dirk-thomas
Copy link
Member Author

@ros/ros_team Please review.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsinnet
Copy link

rsinnet commented Jan 30, 2017

@dirk-thomas Thanks for dealing with the interface compatibility issue. I hadn't thought of the interface as a public interface but that's a very good point. I did a quick smoke test and it seems fine. The changes look good as well.

@dirk-thomas
Copy link
Member Author

Thanks.

@dirk-thomas dirk-thomas merged commit f9cad28 into kinetic-devel Jan 30, 2017
@dirk-thomas dirk-thomas deleted the skipped_tests branch January 30, 2017 18:27
dirk-thomas added a commit that referenced this pull request Feb 28, 2017
* Fixes #839: Adding disabled tests to catkin_test_results summary.

* maintain public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants