Changed the build type to ament_python and Fixed package to run with ros2 run #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
May 14, 2020
|
Please update the title that the PR actually changes the build type of the package. Same for all the other rqt-related PRs with similar changes. |
ahcorde
changed the title
jacobperron
reviewed
May 26, 2020
jacobperron
approved these changes
May 27, 2020
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
|
Rebased on top of Running CI up to
|
ivanpauno
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
LGTM!
Same comments than here ros-visualization/rqt_msg#8 (review).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed package to run with
ros2 run rqt_publisher rqt_publisher. Related to this issue ros-visualization/rqt_console#20Signed-off-by: ahcorde [email protected]