-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additionally support Qt5 #359
Conversation
2344a1a
to
8341193
Compare
As a follow up of this PR the package |
rqt_bag depends on rqt_plot, so that may need to move as well. |
|
The dependency chain now is |
That is true. A circular dependency on the repository level is not fun and should be avoided. I might create a "relay" package then which just chooses the Qwt version. Then that package can be branches and |
I created a "dependency only" package called That way we can use Qwt 5 for Jade and older and Qwt 6.1 for Kinetic (once it becomes available as a system package or someone creates a custom package which we import into our apt repo). |
With |
I posted on the SIG and am looking forward for feedback on these changes: https://groups.google.com/forum/#!topic/ros-sig-rqt/1zcA4xlQ3E0 |
…ins#359 changes for rqt_image_view
With these patches the same code base can satisfy both of the following use cases (with only minimal
try / except
logic:The version dependency on
python_qt_binding
ensures that the packages which useQtWidgets
are getting the changes from ros-visualization/python_qt_binding#31.This is required for a release into Kinetic.