Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to allow ninja to use make for generators #123

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Fix to allow ninja to use make for generators #123

merged 2 commits into from
Mar 3, 2023

Conversation

mjcarroll
Copy link
Contributor

There is an issue when building qt_gui_cpp with ninja, and it is traced back to python_qt_binding.

This allows ninja to find the make executable and use it for this particular step. The alternative would be to make the generator create ninja-files in addition to makefiles, but that seems like more work, given that make should be available on all platforms.

CMake Error:
  Running

   '/usr/bin/ninja' '-C' '/home/mjcarroll/workspaces/ros2_rolling/build/qt_gui_cpp' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:633: bad $-escape (literal $ must be written as $$)

@mjcarroll mjcarroll requested a review from sloretz as a code owner March 1, 2023 16:26
clalancette
clalancette reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question inline.

cmake/sip_helper.cmake Outdated Show resolved Hide resolved
@mjcarroll @clalancette
Find make binary on all non-Windows platforms
6bb4541 
Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Chris Lalancette <[email protected]>
clalancette
clalancette approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@mjcarroll
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit ade88c5 into rolling Mar 3, 2023
@mjcarroll mjcarroll deleted the mjcarroll/ninja_sip_generator branch March 3, 2023 14:40
yashi pushed a commit to yashi/python_qt_binding that referenced this pull request Sep 29, 2023
@mjcarroll @clalancette @yashi
Fix to allow ninja to use make for generators (ros-visualization#123)
566979a 
[ Upstream commit ade88c5 ]

Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Oct 17, 2023
@yashi @mjcarroll @clalancette
Fix to allow ninja to use make for generators (#123) (#128)
2cc0552 
[ Upstream commit ade88c5 ]

Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
@peci1
Copy link

peci1 commented May 10, 2024

Could I ask for this to be backported to Noetic? It prevents me from building RViz with ninja: #111 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @peci1 @clalancette