Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Add linter for plaintext English #77

Closed
wants to merge 1 commit into from
Closed

Conversation

thomas-moulard
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #77 into master will decrease coverage by 2.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   65.18%   62.86%   -2.32%     
==========================================
  Files           4        4              
  Lines         247      272      +25     
==========================================
+ Hits          161      171      +10     
- Misses         86      101      +15
Flag Coverage Δ
#unittests 62.86% <ø> (-2.32%) ⬇️
Impacted Files Coverage Δ
cross_compile/sysroot_compiler.py 62.96% <0%> (-2.67%) ⬇️
cross_compile/ros2_cross_compile.py 0% <0%> (ø) ⬆️
test/test_sysroot_compiler.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39a922...0c46e8c. Read the comment docs.

@zmichaels11
Copy link
Contributor

##[warning]Failed to download action 'https://api.github.com/repos/gaurav-nelson/github-action-vale-lint/tarball/v0.1.0'. Error Response status code does not indicate success: 404 (Not Found).
##[warning]Back off 10.777999999999999 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/gaurav-nelson/github-action-vale-lint/tarball/v0.1.0'. Error Response status code does not indicate success: 404 (Not Found).
##[warning]Back off 15.716 seconds before retry.
##[error]Response status code does not indicate success: 404 (Not Found).

@thomas-moulard thomas-moulard force-pushed the tmoulard/vale branch 4 times, most recently from ac2d4a9 to dc86302 Compare December 11, 2019 01:09
@thomas-moulard
Copy link
Member Author

The official action is currently broken, let's retry later.

Signed-off-by: Thomas Moulard <[email protected]>
@thomas-moulard
Copy link
Member Author

Blocked on errata-ai/vale-action#6

Copy link

@piraka9011 piraka9011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, codecov needs to be updated tho.

https://github.com/errata-ai/write-good/releases/latest/download/write-good.zip
https://github.com/errata-ai/Google/releases/latest/download/Google.zip
config:
https://gist.githubusercontent.com/thomas-moulard/81e4fc260bddeb4149838b884ba86701/raw/cf331fe24d43fc2f02be4b40c5e83051a9e62130/vale.ini

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to host this as part of the repo or in a separate repo/gist?

@emersonknapp emersonknapp mentioned this pull request Jan 2, 2020
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants