Compile flags non-virtual-destructor

[jwallace42]

---

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	NONE
Primary OS tested on	Ubuntu
Robotic platform tested on	NONE

---

Description of contribution in a few bullet points

Added the flag non-virtual destructor to the compile flags. This flag warns the user if a class with virtual functions has a non-virtual destructor. This helps catch hard to track down memory errors.

Description of documentation updates required from your changes

---

Future work that may be required in bullet points

Future compile flags could be added from https://github.com/cpp-best-practices/cppbestpractices/blob/master/02-Use_the_Tools_Available.md.

Adding flags from this list might be a good first issue.

For Maintainers:

• Check that any new parameters added are updated in navigation.ros.org
• Check that any significant change is added to the migration guide
• Check that any new features OR changes to existing behaviors are reflected in the tuning guide
• Check that any new functions have Doxygen added
• Check that any new features have test coverage
• Check that any new plugins is added to the plugins page
• If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

[SteveMacenski]

@jwallace42 the build failed due to warnings this elevated into build errors in the system tests package

[SteveMacenski]

Linty linty https://app.circleci.com/pipelines/github/ros-planning/navigation2/9455/workflows/bcc4e2ec-4f5b-415c-a3f7-c9c22485c205/jobs/30370/tests

[jwallace42]

@Ryanf55 this is the pr I was discussing in the working group yesterday. This was the list of the compile flags I was looking to implement. https://github.com/cpp-best-practices/cppbestpractices/blob/master/02-Use_the_Tools_Available.md

In particular, the -Wold-style-cast will fail if RCLCPP_<level>_THROTTLE is called. If your able to add more compile flags from the list that would be awesome. :)

[Ryanf55]

@Ryanf55 this is the pr I was discussing in the working group yesterday. This was the list of the compile flags I was looking to implement. https://github.com/cpp-best-practices/cppbestpractices/blob/master/02-Use_the_Tools_Available.md

In particular, the -Wold-style-cast will fail if RCLCPP_<level>_THROTTLE is called. If your able to add more compile flags from the list that would be awesome. :)

Thanks, yea I agree that reference is great. I have a few ideas.

[Ryanf55]

Hey there, I went to go build rolling, but now get this build warning, which is now treated as an error. I can't compile main successfully.

--- stderr: nav2_amcl                                                                                                                                                                                                                                   
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: all warnings being treated as errors
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
cc1: error: command-line option ‘-Wnon-virtual-dtor’ is valid for C++/ObjC++ but not for C [-Werror]
gmake[2]: *** [src/pf/CMakeFiles/pf_lib.dir/build.make:146: src/pf/CMakeFiles/pf_lib.dir/pf_draw.c.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors

gcc: 11.3.0

Testing out the commit right before is no issue.