Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using the override keyword for simple_publisher_plugin. #285

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Switch to using the override keyword for simple_publisher_plugin. #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions image_transport/include/image_transport/simple_publisher_plugin.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,21 @@ class SimplePublisherPlugin : public PublisherPlugin
public:
virtual ~SimplePublisherPlugin() {}

virtual size_t getNumSubscribers() const
size_t getNumSubscribers() const override
{
if (simple_impl_) {
return simple_impl_->pub_->get_subscription_count();
}
return 0;
}

virtual std::string getTopic() const
std::string getTopic() const override
{
if (simple_impl_) {return simple_impl_->pub_->get_topic_name();}
return std::string();
}

virtual void publish(const sensor_msgs::msg::Image & message) const
void publish(const sensor_msgs::msg::Image & message) const override
{
if (!simple_impl_ || !simple_impl_->pub_) {
auto logger = simple_impl_ ? simple_impl_->logger_ : rclcpp::get_logger("image_transport");
Expand All @@ -92,7 +92,7 @@ class SimplePublisherPlugin : public PublisherPlugin
publish(message, bindInternalPublisher(simple_impl_->pub_.get()));
}

virtual void shutdown()
void shutdown() override
{
simple_impl_.reset();
}
Expand Down