-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Recover] possible use-after-free bug in nav2_costmap_2d::FootprintSubscriber::getFootprint() #2507
Comments
What is your actual issue? You've provided alot of GDB output, but its unrealistic for me to try to fish through that if I don't understand what your problem is. If you have a solution, please submit a PR. Right now, I don't see an issue. |
Get footprint checks
so it would fail if the callback was not yet triggered. that boolean is only set to true after the
|
Thanks for your reply! Every times a new message received from footprint_topic, footprint_callback will be called.
Every times the recover try to spin, getFootprint will be called
Those mean that getFootprint() and footprint_callback() could run multiple times and run concurrently |
Lets chat in the PR |
Merging once we have CI turning over, closing issue since solution was approved. |
Bug report
Required Info:
Steps to reproduce issue
I had done some tests. And it can be reproduced.
I manually reviewed the related code and found the possible cause.
It looks like a bug of data race, but I can't be sure.
Expected behavior
Process should not crash.
Actual behavior
The text was updated successfully, but these errors were encountered: