Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests created after Galactic release #2433

Closed
SteveMacenski opened this issue Jul 2, 2021 · 4 comments
Closed

Fix broken tests created after Galactic release #2433

SteveMacenski opened this issue Jul 2, 2021 · 4 comments
Labels
1 - High High Priority bug Something isn't working in progress

Comments

@SteveMacenski
Copy link
Member

Since the Galactic release, our CI has been introduced with a number of failing tests. We fixed the trivial ones of linter profile changes, but there are still several nav2_utils tests that are failing that probably just need to be tweaked to pass again.

Goal: Look over the failures in CI, resolve them, and merge into the main branch

@SteveMacenski SteveMacenski added bug Something isn't working 1 - High High Priority labels Jul 2, 2021
@karl-schulz
Copy link
Contributor

Hi,
is this issue the reason why the Nav2 binaries for galactic are not yet available? Or are they just not released yet for other reasons?

sudo -H apt-get install -y -qq ros-galactic-nav2-core
yields
E: Unable to locate package ros-galactic-nav2-core

@SteveMacenski
Copy link
Member Author

We're just waiting on a Galactic sync. I barely missed the first release of Galactic so some of the packages made it through and some did not. They're going to do a sync in the next few days so you should be able to get binaries then, the test failures in CI didn't block that.

@SteveMacenski
Copy link
Member Author

We have flaky tests now, which is a slightly different problem. The core of this has been addressed and CI is turning over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - High High Priority bug Something isn't working in progress
Projects
None yet
Development

No branches or pull requests

2 participants