Begin implementing the pr-only option. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenh1
force-pushed
the
add-pr-only-option
branch
3 times, most recently
from
b325653
to
ae0c5a1
Compare
|
I think I'll catch the OpenEmbedded args up at a later date. Next step: add a configureable repo-directory option. |
tfoote
reviewed
Aug 7, 2017
| @@ -19,14 +19,14 @@ def get_random_branch_name(): | |||
|
|
|||
|
|
|||
| class ros_overlay(repo_instance): | |||
| def __init__(self): | |||
| def __init__(self, existing_repo=None): | |||
There was a problem hiding this comment.
It would appear not -- good catch.
superflore/repo_instance.py
Outdated
| @@ -19,7 +19,7 @@ | |||
|
|
|||
|
|
|||
| class repo_instance(object): | |||
There was a problem hiding this comment.
This class should be RepoInstance
| @@ -19,14 +19,14 @@ def get_random_branch_name(): | |||
|
|
|||
|
|
|||
| class ros_overlay(repo_instance): | |||
There was a problem hiding this comment.
This class should be CamelCased as well.
There was a problem hiding this comment.
Looking at the initialization. Do you really need the inheritance here or can you just have the repo_instance as a member?
There was a problem hiding this comment.
That's a good point.
I think I should also move the pull_request function into RepoInstance
| @@ -19,14 +19,14 @@ def get_random_branch_name(): | |||
|
|
|||
|
|
|||
| class ros_overlay(repo_instance): | |||
| def __init__(self): | |||
| def __init__(self, existing_repo=None): | |||
| # clone repo into a random tmp directory. | |||
| repo_instance.__init__(self, 'ros', | |||
There was a problem hiding this comment.
Use super to init the base class. lots of details here: https://stackoverflow.com/questions/576169/understanding-python-super-with-init-methods
allenh1
force-pushed
the
add-pr-only-option
branch
from
eaf1e10
to
d73de45
Compare
allenh1
commented
Aug 8, 2017
| @@ -13,7 +13,8 @@ | |||
| # limitations under the License. | |||
|
|
|||
|
|
|||
| from superflore import repo_instance | |||
| # TODO(allenh1): remove inheritance like the RosOverlay class. | |||
| from superflore import RepoInstance as repo_instance | |||
There was a problem hiding this comment.
This is a temporary hacky-fix to avoid breaking things in the OpenEmbedded world. This will be updated when I catch OpenEmbedded up.
…bmitted by dry run.
removed inheritance for the RosOverlay class in favor of having a RepoInstance object.
allenh1
force-pushed
the
add-pr-only-option
branch
from
9d0b840
to
113fd89
Compare
|
@tfoote rebased on top of master. Ready for review. |
tfoote
approved these changes
Aug 9, 2017
allenh1
added a commit
that referenced
this pull request
Oct 31, 2017
…itance to be a member of the class (see #52).
allenh1
added a commit
that referenced
this pull request
Nov 2, 2017
* Switch to use util functions. * Use the generate_installers function from superflore.generate_installers * Linting * Change the ros_meta class to be RosMeta, as well as changed the inheritance to be a member of the class (see #52). * Removed the sym-linked structure to behave more like the Gentoo generator (see #51). * Removed a commented line from the ebuild logic copypasta, changed the print format slightly for the exception output after a failed pr, and called the file_pr function. * Add temporary file manager code, as suggested by @tfoote. * Switch to utils print functions for TempfileManager output. * Use tempfile manager to clean up temp directories at exit. * Linting. * Remove hard-coded org and repo from RepoInstance call. * Reorder import statements. * Ok, that's pretty cool. * Apply new TempfileManager usage to OpenEmbedded logic. * OpenEmbedded generation is now running. ToDo: automatically clean up the tar files. * Files were not generating in the directory, but are now. * Fixed argument mapping for ebuild generator.
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* Switch to use util functions. * Use the generate_installers function from superflore.generate_installers * Linting * Change the ros_meta class to be RosMeta, as well as changed the inheritance to be a member of the class (see ros-infrastructure#52). * Removed the sym-linked structure to behave more like the Gentoo generator (see ros-infrastructure#51). * Removed a commented line from the ebuild logic copypasta, changed the print format slightly for the exception output after a failed pr, and called the file_pr function. * Add temporary file manager code, as suggested by @tfoote. * Switch to utils print functions for TempfileManager output. * Use tempfile manager to clean up temp directories at exit. * Linting. * Remove hard-coded org and repo from RepoInstance call. * Reorder import statements. * Ok, that's pretty cool. * Apply new TempfileManager usage to OpenEmbedded logic. * OpenEmbedded generation is now running. ToDo: automatically clean up the tar files. * Files were not generating in the directory, but are now. * Fixed argument mapping for ebuild generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #49