Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "license-org" and "license-text" parameters #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JasonShigit
Copy link

If "license-org" and license-text" are passing in command line, the default value will be overlayed in generated files.

@JasonShigit
Copy link
Author

@allenh1 Could you please review and comment?
Test pass with my meta-ros env.

If "license-org" and license-text" are passing in command line, the
default value will be overlayed in generated files.

Signed-off-by: Jason Shi <[email protected]>
@allenh1
Copy link
Collaborator

allenh1 commented May 31, 2023

@JasonShigit sorry for the delay! I'm running CI on it now.

allenh1
allenh1 previously approved these changes May 31, 2023
Copy link
Collaborator

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JasonShigit
Copy link
Author

Hi @allenh1
Thanks for help. The test failed and i updated one more change for test_ebuild.py. Is there any guidance for running tests locally?

@allenh1
Copy link
Collaborator

allenh1 commented Jun 6, 2023

@JasonShigit it seems there are still a few errors to resolve.

The best way to run locally is to install all the requirements (see requirements.txt), and run pytest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants