Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate package conditions when generating ebuilds #294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nuclearsandwich
Copy link
Contributor

ebuild generation was not utilizing package conditions.
Packages with multiple build types were causing hard failures during
ebuild generation but it's possible that invalid ebuilds were being
generated for other packages as well due to the lack of dependency
conditions.

Fixes #289.

This `pkg` argument is shadowed by a local variable without first being
used.
Ebuild generation was not utilizing package conditions.
Packages with multiple build types were causing hard failures during
ebuild generation but it's possible that invalid ebuilds were being
generated for other packages as well due to the lack of dependency
conditions.
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. It looks like we need more updates to validate it well. CI's now running on what looks to be EOL platforms.

@nuclearsandwich
Copy link
Contributor Author

It looks like we need more updates to validate it well. CI's now running on what looks to be EOL platforms.

Yeah, I built this based on the similar support for the oe platform, which doesn't rely on docker for any part of its process. I would be inclined to merge this as-is since bringing CI back online for the Gentoo side is going to be a large investment. I think the next PR I would make would update CI platforms and disable Gentoo tests entirely in order to allow CI to continue for the OpenEmbedded/Yocto people still using the tool regularly.

@nuclearsandwich
Copy link
Contributor Author

I would be inclined to merge this as-is since bringing CI back online for the Gentoo side is going to be a large investment.

I'll hold onto this until the end of the week in case I am struck with any further inspiration here. Then I'll merge unless there's an objection.

Copy link
Collaborator

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

I agree fixing CI is probably out of the scope of this PR ;). Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catkin_pkg.package.InvalidPackage: Only one <build_type> element is permitted
3 participants