-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust PR message stating how superflore was executed #214
Adjust PR message stating how superflore was executed #214
Conversation
@allenh1 << Ptal |
@andre-rosa I am going to let @tfoote decide on this. I was okay with the way it was worded before, but you make a good point here. Tully is definitely better at wording things than I, so I'd like his input before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change that it's not reproducible makes sense. But I agree with @allenh1 that issuing is not clear to the user.
feb2e0a
to
3205491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andre-rosa very small fix left
3205491
to
e758c16
Compare
- In fact, it's not possible to reproduce the PR fully by running again as superflore makes use of remote metadata. So state that instead of reproducing the PR, it'll list the command used originally.
e758c16
to
caec76f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ture#214) - In fact, it's not possible to reproduce the PR fully by running again as superflore makes use of remote metadata. So state that instead of reproducing the PR, it'll list the command used originally.
as superflore makes use of remote metadata. So state that instead of
reproducing the PR, it'll list the command used originally.
Fixes #213 .